Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !64

Improve flash performance and formatting

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge gw-flashes into master Aug 31, 2015
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 6

Created by: gracewashere

Why?

  • Flashes were being set using the flash[:alert] = syntax, which saves the flash for the next request the user makes (used during redirects, etc).
  • When users visited the index page and then clicked through to another page, they would still see the index page's flash from the previous request.

This commit switches to the flash.now[:alert] = syntax, which only sets the flash for the current request.

Also, switch flashes to use BEM syntax.

Tags: #ruby #design

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gw-flashes