Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !727

Add link to show resource from collection table

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge op-add-show-link into master Jan 06, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 4

Created by: odlp

Adds a link to show the resource within each cell of the collection table, as an alternative to the data-url on the tr. The link is styled with the default text colour so there's no visual change.

This allows a resource to be shown without javascript enabled (and also facilitates faster tests using RackTest).

On my machine running the same test comparing:

  • click_show_link_for (+ no JS)
  • click_row_for (+ with JS)

is a lot faster, as expected:

Run no JS JS
1 0.88 2.04
2 0.85 1.93
3 0.85 1.96
4 0.84 2.02
5 0.82 2.04
Avg 0.85 2.00
Std.Dev 0.02 0.05

(in seconds, running each test independently, excluding file load times)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: op-add-show-link