Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !74

Align number fields to the right in tables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge gw-right-align-numbers into master Sep 03, 2015
  • Overview 5
  • Commits 1
  • Pipelines 0
  • Changes 10

Created by: gracewashere

Why?

  • It's easiest to read numbers in a table if they're right-aligned

Changes:

  • Switch table elements to BEM syntax
    • not sure if this is best practice, because the field elements are not all contained in a single .field div.
    • I like it because on index and show pages, we can reuse the classes, and wrap them in a .field div there.
  • Move html_class from instance to class method on Field::Base so we can use the field type to align the table headers.

administrate

Tags: #ruby #design

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gw-right-align-numbers