Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !762

Fix pagination specs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge jm-fix-mock-in-spec into master Mar 03, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: jcmorrow

The MockRelation class did not implement page or per so some specs which rely on those methods were failing. Also, some content matchers were not specific enough, so I've made those more specific and added some helper methods.

Changes:

  • Add some methods to MockRelation
  • Make content matchers more specific to make spec more resilient to different ID's of related items
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jm-fix-mock-in-spec