Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !797

Stop using Sass glob importing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-sass-imports into master Mar 24, 2017
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: tysongach

Glob importing is a feature of sass-rails. It makes for cleanly and easily importing lots of partials, but it completely hides Sass errors.

For example, when you miss a semicolon and your Sass doesn't compile, using glob imports with sass-rails you simply see an application error: "We're sorry, but something went wrong."

But when using standard Sass imports, this error is an actual syntax error, which provides helpful messaging ("Invalid CSS after…"), and traces back to the source where the error was introduced.

Before

screen shot 2017-03-24 at 14 49 48

After

screen shot 2017-03-24 at 14 50 07

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-sass-imports