Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !823

Do not redirect to show page when selecting text

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dsolomadin/ds-selection-fix into master Apr 10, 2017
  • Overview 6
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: dsolomadin

This PR fixes the problem when user wants to select text on index page but instead we redirect them to show page of particular record.

Here is how it works:

screencast 2017-04-10 15-23-43

I've also tried to write a test on this, but looks like Capybara (Poltergeist?) does not support getSelection API.

Fixes #770 (closed)

/r @carlosramireziii /cc @stevenmilton58

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/dsolomadin/ds-selection-fix