Allow rails 5.1 usage (!856) · Merge requests · thoughtbot, inc. / administrate

Merged Administrator requested to merge github/fork/tiagoamaro/allow-rails-5-1 into master May 03, 2017

Created by: tiagoamaro

Hello,

First, thank you very much for this gem! It's extremely useful, as its code is quite impressive and clean 🎉 very nice job!

This PR is my attempt to allow Rails 5.1 usage, while keeping the entire test suite green. There are some deprecation warnings, but they're related to database_cleaner:

DEPRECATION WARNING: schema_migrations_table_name is deprecated and will be removed from Rails 5.2 (called from block (2 levels) in <top (required)> at /Users/tiago/Projects/test_apps/administrate/spec/support/database_cleaner.rb:11)

Ran bundle exec rake && bundle exec appraisal rake and everything passed fine :) Also, I'm currently using my fork on a project in production, and it seems to be working fine.

Note: I've noticed a PR to support Rails 5.1 (https://github.com/thoughtbot/administrate/pull/782), but it seems it's tackling more than just allowing this new Rails version to be used, so I decided to open this one.