Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !861

Tweak primary navigation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-navigation into master May 05, 2017
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 15

Created by: tysongach

  • Rename sidebar to navigation, which is based on its purpose rather than its visual placement.
  • Use nav element.
  • Remove unnecessary ul; the nav provides enough semantics to wrap the links in.
  • Tweak visual design: show a light background on hover, add more whitespace between navigation links and main content.

After this PR:

screen shot 2017-05-05 at 15 19 15 (“Orders” is being hovered)

Before:

screen shot 2017-05-05 at 15 22 48

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-navigation