Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !867

Refine look-and-feel

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-layout into master May 06, 2017
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 17

Created by: tysongach

  • Clean up primary layout
    • Merge the header style component into main-content, which simplifies and reduces the Sass and gives us a BEM relationship for main-content__header and main-content__body to share styles.
    • Add some viewport-height-based padding to the bottom of the main content area so that the "save" button on forms is not shoved to the bottom of the screen.
    • Add a section element that wraps the body of the main content, to help make markup consistent across screens.
  • Redesign tables
    • Slightly decrease font size of table content
    • Collapse table borders, to prevent gaps between cells
    • Define table styles as base HTML element styling
    • Refine table row focus outline
    • Prefix classes used for JavaScript interactions with js-
  • Tweak colors
    • Use more saturated red and blue colors so that they pass WCAG contrast guidelines.
    • Related: #794

After this PR:

screen shot 2017-05-06 at 11 14 33 screen shot 2017-05-06 at 11 14 45

Before:

screen shot 2017-05-06 at 11 15 20

screen shot 2017-05-06 at 11 15 12

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-layout