Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !881

Redesign search

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge tg-search into master May 10, 2017
  • Overview 10
  • Commits 1
  • Pipelines 0
  • Changes 30

Created by: tysongach

  • Moved the search into the main content header to make better use of vertical space in the layout.
  • Search is now visually (and in the DOM) after the page title, which makes for a more logical and expected flow because it is a page-based search.
  • Improved accessibility:
    • Navigating the search via keyboard now works in Safari.
    • Meaningful accessible names and labels were added.
    • Include the name of the resource being searched in labels.
  • Reduced the CSS needed for search by 44%.
  • Remove unnecessary content_for helper that wrapped the rendering of the search partial.

Note: This PR depends on #880 being merged.

Before

screen shot 2017-05-10 at 16 12 30

After

screen shot 2017-05-10 at 16 12 18

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tg-search