Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • A administrate
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 96
    • Issues 96
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • thoughtbot, inc.
  • administrate
  • Merge requests
  • !97

Improve consistency of label visual styles

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge form-labels into master Oct 12, 2015
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 13

Created by: gracewashere

Problem:

A resource's show page and edit page had different styles for their field labels, which worked against the cohesion of the site.

Solution:

  • Extract a data-label mixin
  • Use the mixin in the form, the attribute label (show page), and in the index table cells

Minor changes:

  • Improve BEM-iness of form-field-has-many
  • Break up _show.sass into component-related stylesheets
  • Improve spacing under page header

Preview

"Show" page administrate

"Edit" page administrate

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: form-labels