Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • J jruby-maven-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The TorqueBox Project
  • jruby-maven-plugins
  • Merge requests
  • !106

adds compatibility to install gems with jruby > 9.2.10.x

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/abelsromero/fix-compatibility-with-jruby-9-2-10-0-or-higher into master May 24, 2020
  • Overview 31
  • Commits 6
  • Pipelines 0
  • Changes 64

Created by: abelsromero

This PR fixes #105 (closed) by checking the Ruby language version. If 2.6 or higher, it will replace the rdoc and ri arguments (noew deprecated) by the supported document. Older versions of Ruby runtimes will work same as now.

Only thing I am not confident is that when running mvn clean test -pl gem-maven-plugin -am I get this error gem-maven-plugin: Execution default of goal org.apache.maven.plugins:maven-plugin-plugin:3.4:helpmojo failed: The source must not be a directory. Any idea?

It also:

  • Adds Idea files to .gitignore
  • Fixes artifactId in rubygems-in-test-resources-failure test. This caused false positives when running all IT tests (those run by maven-invoker-plugin) in a specific order.
  • Fixes test include-rubygems-in-test-resources adding the correct dependency. This worked due to previoud comment, but failed when run in isolation.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/abelsromero/fix-compatibility-with-jruby-9-2-10-0-or-higher