Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • J jruby-maven-plugins
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The TorqueBox Project
  • jruby-maven-plugins
  • Merge requests
  • !19

Default value for result message on RSpecMojo

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/dobozysaurus/master into master 14 years ago
  • Overview 3
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: dobozysaurus

RSpecMojo has a small bug on the calculation of success or failure: it is possible for RSpecMojo.runIt to execute without ever assigning a value to its JRubyRun.Result.message instance, since a message value is only assigned if RSpecMojo finds a line containing the words "failure" and "example". If that happens, it will cause an NPE when calculating success on the last line of that method.

The fix creates a default message ("An unknown error occurred" and sets the result success flag to false.

Approval is optional

Merged by Christian MeierChristian Meier 14 years ago (Jun 28, 2011 4:56pm UTC) 14 years ago

Merge details

  • Changes merged into master with e00452fd.
  • Deleted the source branch.

Activity


  • Administrator
    Administrator @root · 14 years ago
    Author Contributor

    Merged by: mkristian at 2011-06-28 16:56:23 UTC

  • Christian Meier closed 14 years ago

    closed

  • Christian Meier
    Christian Meier @mkristian · 14 years ago

    thanx !

  • Administrator
    Administrator @root · 14 years ago
    Author Contributor

    Created by: dobozysaurus

    No worries - happy to help!

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
2
2 participants
Administrator
Christian Meier
Reference: torquebox/jruby-maven-plugins!19
Source branch: github/fork/dobozysaurus/master

Menu

Explore Projects Groups Snippets