Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #10966
Closed
Open
Issue created Oct 07, 2013 by Administrator@rootContributor

Collapsible `parent` option is dependent on dom structure

Created by: steodor

Hi, i found this pull request: https://github.com/twbs/bootstrap/pull/7600

In the latest version i see that the parent option is now dependent on the .panel class, i.e.:

var actives = this.$parent && this.$parent.find('> .panel > .in')

Why don't you just leave it like it was (.collapse.in) or better yet, just:

var actives = this.$parent && this.$parent.find('.in')

Or, i get it if the parent must have a class, to avoid conflicts with other libraries, but can you please explain what's up with depending on dom structure? (the double > in the selector really don't look good to me)

Oh and, the docs are way behind on this one. There's an .accordion-group class mentioned, but not saying how it should be used, and the example doesn't have one at all (yet it works, probably on an old bootstrap version).

So basically, please decide on a structure and update the docs & examples accordingly. If you want i could help you with some of the workload, as you see fit.

Thank you.

Assignee
Assign to
Time tracking