Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #12162
Closed
Open
Issue created Jan 09, 2014 by Administrator@rootContributor

Hardcoded font name value & Incorrect value

Created by: thomaswelton

https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L17

This font face declaration is setup to reference the font name as a variable. However the SVG font ID after the hash is hard coded.

Though this is not really an issue it could later become a problem if the font name and SVG font ID changes, and only the variable is updated and not properly tested.

Will submit a PR that uses a new variable @icon-font-svg-id

  • Edit *

Further more the font icon ID is incorrect https://github.com/twbs/bootstrap/blob/master/less/glyphicons.less#L17 https://github.com/twbs/bootstrap/blob/master/fonts/glyphicons-halflings-regular.svg#L6

glyphicons_halflingsregular vs glyphicons-halflingsregular

Assignee
Assign to
Time tracking