Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #16767
Closed
Open
Issue created Jul 05, 2015 by Administrator@rootContributor

Color of buttons that are active and disabled

Created by: seyfert

I am using a button group as a form input (using data-toggle="buttons"). After the user submits the form, the form is temporarily disabled while the data is being processed. I would expect that while the buttons are disabled it would still be possible to identify which (if any) buttons are selected ('active'). However, the button-variant mixin overrides the color for all states when the button is disabled so every disabled button variant looks the same.

From a usability perspective the current behavior is not ideal because the user may be confused to think that their selections were lost when the form was disabled.

You can see an example of the issue here: http://codepen.io/seyfert/pen/oXqgNN?editors=111 http://codepen.io/seyfert/pen/PqRwXR?editors=101

I think the appropriate fix would be to modify the "disabled" styling in button-variant mixin so only "hover" and "focus" states use the default color for disabled buttons.

See https://github.com/seyfert/bootstrap/commit/11f785060a94f978cd5bdfcbb4064db39143b09d

Assignee
Assign to
Time tracking