Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #18630
Closed
Open
Issue created Dec 22, 2015 by Administrator@rootContributor

nav links inconsistencies

Created by: bassjobsen

https://github.com/twbs/bootstrap/issues/18623 tells me that $nav-link-hover-bg is an unused variable. When looking to the nav links (in scss/_nav.scss) i found that:

  1. i can not style the link's color and :hover color using variables
  2. but i can style the disabled state color by $nav-disabled-link-color and $nav-disabled-link-hover-color

The nav links (.nav-link) inherit their color and :hover color from the a selector set in scss/reboot.scss.

Some suggestions to solve these inconsistencies

  1. set the disabled state for the a selectors in scss/reboot.scss and remove it from the nav code

  2. create (and) use variables for all (normal, hover, active and disabled states), like: $nav-link-color: $link-color !default; $nav-link-bg: transparent !default;

    $nav-link-hover-color: $link-hover-color !default; $nav-link-hover-decoration: $link-hover-decoration; $nav-link-hover-bg: transparent !default;

    $nav-active-link-color: $component-active-color !default; $nav-active-link-hover-color: $component-active-color !default; $nav-active-link-hover-bg: transparent !default;

    $nav-disabled-link-color: $gray-light !default; $nav-disabled-link-hover-color: $gray-light !default; $nav-disabled-link-hover-bg: transparent !default;

  3. do both 1. and 2.

I'm not sure why for instance $nav-link-color does not exists yet. Personally i think we should implement 3. because of it does not change anything for the default, but enables you to configure the nav (and other components) by setting some variables.

Assignee
Assign to
Time tracking