Skip to content
GitLab
Closed
Issue created by Administrator@rootContributor

Bootstrap 4 + jQuery 3 unit test failures/errors

Created by: cvrebert

Running https://github.com/twbs/bootstrap/blob/v4-dev/js/tests/index.html with jQuery v3.0.0 swapped in, I encountered the following failures/errors. Haven't yet investigated/diagnosed them. @dmethvin Pinging you per your request in #19433 (closed).

Chrome + Safari

Intermittent test failure

(Sometimes fails earlier/later within the set of 5 assertions)

scrollspy: should correctly select navigation element on backward scrolling when each target section height is 100% (1, 2, 3) Rerun Expected 5 assertions, but 4 were run Source:
at HTMLDocument.<anonymous> (file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:288:9) at mightThrow (file:///Users/chris/code/bootstrap/js/tests/vendor/jquery.min.js:3505:29) at process (file:///Users/chris/code/bootstrap/js/tests/vendor/jquery.min.js:3573:12)

Intermittent console error

jQuery.Deferred exception: Cannot read property 'top' of undefined TypeError: Cannot read property 'top' of undefined at testElementIsActiveAfterScroll (file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:316:79) at file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:329:34 at mightThrow (file:///Users/chris/code/bootstrap/js/tests/vendor/jquery.min.js:3505:29) at process (file:///Users/chris/code/bootstrap/js/tests/vendor/jquery.min.js:3573:12) undefined

Firefox

Consistent test failure

scrollspy: should correctly select navigation element on backward scrolling when each target section height is 100% (1, 3, 4) Rerun jQuery.Deferred exception: $(...).position(...) is undefined testElementIsActiveAfterScroll@file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:316:59 @file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:328:34 (or :329:34 or :330:34 ; varies between test runs) ScrollSpy@file:///Users/chris/code/bootstrap/js/dist/scrollspy.js:91:7

Intermittent test failure

Intermittent FAIL: scrollspy: should add the active class to the correct element (1, 1, 2) Rerun 32 ms Expected 2 assertions, but 1 were run Source: @file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:171:3 resolve/

Intermittent console error

jQuery.Deferred exception: $(...).position(...) is undefined testElementIsActiveAfterScroll@file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:193:59 @file:///Users/chris/code/bootstrap/js/tests/unit/scrollspy.js:205:34 ScrollSpy@file:///Users/chris/code/bootstrap/js/dist/scrollspy.js:91:7

IE and MS Edge

Not Yet Tested.