Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #20609
Closed
Open
Issue created Sep 01, 2016 by Administrator@rootContributor

Change button outline to work with lighter colours

Created by: eliottrobson

The mixin button-outline-variant currently has hardcoded values to make the colour of the text white. When using it with lighter colours (for example yellow on a dark themed website) the white is lost to the button background on hover / focus / active.

Instead I think there are 2 solutions to this:

  1. Change the mixin to accept a second parameter, $text. This will work in a very similar way to button-variant.

  2. Change the mixin to do a quick @if (lightness($color) > 50) { check and set it to fff or 000 as necessary.

Assignee
Assign to
Time tracking