Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #23119
Closed
Open
Issue created Jul 19, 2017 by Administrator@rootContributor

$line-height-sm/-lg is confusing

Created by: ahmetb

https://github.com/twbs/bootstrap/blob/082c9d92fe1057f8dddda32e1002983d82c681aa/scss/_variables.scss#L211-L212

These two variables $line-height-sm and $line-height-lg give the impression that they're used for body { line-height: ... }, however they're only used in scss/_buttons.scss and scss/_pagination.scss. It seems like $line-height-base is the correct one to edit.

Please consider renaming those to distinguish.

Assignee
Assign to
Time tracking