Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #26953
Closed
Open
Issue created Jul 24, 2018 by Administrator@rootContributor

Form variable definitions appear inconsistent

Created by: Dagothig

Both forms and buttons share variable definitions form the $input-btn- line of variables. However some of the computed default values use the $input-btn- variables rather than the $input- ones. For instance inner height is defined as ($font-size-base * $input-btn-line-height) + ($input-btn-padding-y * 2). Each of these btn variables is also defined so it means that changing the input line height doesn't change the actual input height, but changing the input btn line height does, which comes off as a little surprising.

In a similar manner, the $custom-select variables mix both $input-btn and $input variables when all of the variables are defined by $input.

Overall this leads to situations where overriding all the $input variables only partially changes the values that are used (so for instance the custom select's height does not match the other input heights).

Assignee
Assign to
Time tracking