Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #27836
Closed
Open
Issue created Dec 14, 2018 by Administrator@rootContributor

Add $gutter parameter (with default value) to mixins make-container and make-row?

Created by: florianlacreuse

Hi,

I noticed that both mixins make-container and make-row use directly the variable $grid-gutter-width while mixin make-grid-columns use a parameter $gutter with default value as $grid-gutter-width.

Is there a reason I don't know about?

If not it would be useful in some cases to add this parameter $gutter: $grid-gutter-width to both mixins.

https://github.com/twbs/bootstrap/blob/c031584bcde710841ef4324558f40242080c53a9/scss/mixins/_grid.scss#L23-L28

https://github.com/twbs/bootstrap/blob/c031584bcde710841ef4324558f40242080c53a9/scss/mixins/_grid-framework.scss#L6-L13

If you give me the go-ahead, i can do a PR.

Kind regards.

Assignee
Assign to
Time tracking