Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #28399
Closed
Open
Issue created Mar 04, 2019 by Administrator@rootContributor

Mixing percentual and pixel values in $container-max-widths

Created by: mspae

Given this variable override value:

$container-max-widths: map-merge(
  (
    sm: 100%,
    md: 90%,
    lg: 90%,
    xl: 1440px,
  ),
  $container-max-widths
);

The _assert-ascending function fails because px and percent values are not comparable.

Maps which only contain percentages work, because of this fix https://github.com/twbs/bootstrap/pull/26689 – However this does not work if the map contains both types.

I believe this is a valid (and common) use case: There should be a maximum size for the container from a certain viewport width onward, before then the container should be flexible.

Conversely it could be possible that the container should turn into a percentual width from a certain viewport width onward.

Assignee
Assign to
Time tracking