Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #28423
Closed
Open
Issue created Mar 07, 2019 by Administrator@rootContributor

Non ul or ol based .nav-link should require .nav-item class

Created by: ysds

The non ul or ol based navs e.g.

<nav class="nav">
  <a class="nav-link active" href="#">Active</a>
  <a class="nav-link" href="#">Link</a>
  <a class="nav-link" href="#">Link</a>
</nav>

should be require .nav-item class:

<nav class="nav">
  <a class="nav-item nav-link active" href="#">Active</a>
  <a class="nav-item nav-link" href="#">Link</a>
  <a class="nav-item nav-link" href="#">Link</a>
</nav>

Because there are many snippets without .nav-item class in the docs, so it looks like it's not necessary, but the .nav-item class is often required. As an example, the pill style does not require .nav-item, but the tab style needs it (this usage isn't documented).

image

demo: https://codepen.io/anon/pen/wOJWJo

And the example in the navbar nav use .nav-item with .nav-link.

image

This lack of consistency caused the problem of #28117 (closed).

I strongly recommend add .nav-item to all .nav-link of the non <ul> or <ol> based nav.

Assignee
Assign to
Time tracking