Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #28444
Closed
Open
Issue created Mar 10, 2019 by Administrator@rootContributor

Remove focus & hover states from `bg-variant` mixin

Created by: MartijnCuppens

About this code: https://github.com/twbs/bootstrap/blob/8896827bd072a120705a0576a5bcde69c8ce2cda/scss/mixins/_background-variant.scss#L9-L14

I think we should remove it. IMO focus and hover background states don't belong in these utilities and we are also not defining an active state here. We have the buttons with backgrounds, if this doesn't cover the needs I think the developer will need to write custom code, because it's quite specific.

I guess we can just remove the mixin, just use the background-color property in v5 and use the deprecate mixin to deprecate this in v4.

Thoughts?

Assignee
Assign to
Time tracking