Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #30510
Closed
Open
Issue created Apr 03, 2020 by Administrator@rootContributor

Dropdowns: key events are not propagated from inactive and disabled dropdowns

Created by: luktom

Hi,

key events are not propagated from dropdown when it is inactive or disabled.

Reduced test case on JS Bin: https://jsbin.com/hoharusisa there is ESC key handler attached to the document element.

  1. Click on ESC - nothing happens.
  2. Click on ESC - handler is invoked.

Event propagation is disabled in the https://github.com/twbs/bootstrap/blob/v4-dev/js/src/dropdown.js#L455 just after initial checks which are finishing the event handling, but in following lines there are further check which potentially could finish the handling. Propagation should be stopped after those checks.

Please see related PR with the fix.

Similar finding was created for v3: #15065 (closed) It was found as valid issue: https://github.com/twbs/bootstrap/issues/15065#issuecomment-77530943 however it was never fixed.

Thanks ans Regards, Łukasz

Assignee
Assign to
Time tracking