Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #35490
Closed
Open
Issue created Dec 08, 2021 by Administrator@rootContributor3 of 3 checklist items completed3/3 checklist items

v5: Offcanvas ESC keypress doesn't prevent default

Created by: moeriki

Prerequisites

  • I have searched for duplicate or closed issues
  • I have validated any HTML to avoid common problems
  • I have read the contributing guidelines

Describe the issue

Pressing "Escape" in an open Offcanvas closes it. But the event is propagated to the browser which (ao) makes the browser leave fullscreen mode.

This behaviour is correct in other overlay components such as dropdown and modal.

Reduced test cases

https://codepen.io/moeriki/pen/rNGLBvW

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Safari, Firefox

What version of Bootstrap are you using?

v5.1.3

Fix

The fix might be just adding event.preventDefault() here…

https://github.com/twbs/bootstrap/blob/main/js/src/offcanvas.js#L194

Assignee
Assign to
Time tracking