Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Issues
  • #37778
Closed
Open
Issue created Jan 01, 2023 by Julien Déramond@julien-deramondContributor3 of 3 checklist items completed3/3 checklist items

Navbar/Navs now have a focus ring

Prerequisites

  • I have searched for duplicate or closed issues
  • I have validated any HTML to avoid common problems
  • I have read the contributing guidelines

Describe the issue

https://github.com/twbs/bootstrap/pull/33125 introduced a new helper to handle focus rings.

Since then, we can observe a blue outline while focusing the navbar with the mouse and with the keyboard.

2023-01-01 23 29 15

2023-01-01 23 30 05

2023-01-01 23 30 16

First of all, the outline shouldn't be displayed when the focus is given via the mouse; it should remains given by the keyboard. FWIW we removed this kind of behavior from the buttons not a long time ago.

Secondly, IMO the outline doesn't have enough contrast on our docs navbar, plus the rendering (still IMO) too much differs from the focus displayed on the navbar brand logo and from the skip links.

The possibly corresponding code: https://github.com/twbs/bootstrap/blob/1b39d1275bf5f91ff126faea33a6e6ab71ba991e/scss/_nav.scss#L41-L44

Reduced test cases

Reduced tests cases:

  • https://twbs-bootstrap.netlify.app (main navbar of the docs)
  • https://twbs-bootstrap.netlify.app/docs/5.3/components/navbar/
  • https://twbs-bootstrap.netlify.app/docs/5.3/components/navs-tabs/

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox, Microsoft Edge, Opera

What version of Bootstrap are you using?

main branch

Assignee
Assign to
Time tracking