Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10254

RTL support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/geedmo/master into master Aug 28, 2013
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 35

Created by: geedmo

A few days ago, I've converted a site to rtl using the bi-app mixins for sass. Then I discovered bi-app-less and I think it could be a good approach to bring RTL support for Bootstrap3. Asked on Issue #9913 (closed)

It requires changes across all framework files, but it doesn't overrides styles and has no extra maintenance. Keeping the development with LTR in mind.

The entire framework is configurable via @text-direction variable supporting ltr or rtl

Changes that I can list

  • Replace horizontal rules by its mixin version
  • Removed bs .border-radius mixin to use instead bi-app mixins
  • Added direction to body
  • pre and code maintain direction: ltr
  • Carousel uses custom mixin for left or right transition
  • Popover left/right was left intact
  • Bi-app mixin integrated into the mixins.less
  • docs.css modified for rtl demo

Javascript seems to work fine, I have not fully tested on all browsers. Demo here http://geedmo.github.io/bootstrap-rtl/

May be this is not a valid pull-request but I've created it in order to see the changes and get some feedback. Surely it requires more work Bi-app https://github.com/anasnakawa/bi-app-less

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/geedmo/master