Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10581

Converted hard coded shades of gray to variants of @gray.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/nchapman/master into master Sep 11, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 6

Created by: nchapman

I discovered while attempting to make a theme for Bootstrap that it seemed unnecessarily difficult to tint the color gray used throughout since there is a combination of @gray-* variables and hard set gray hex values used in the variables.less file. To fix this, I changed the @gray variable to be hard set to #555 and used that to set the other shades of gray. I fixed all the places that should have already been using the existing variables and then lightened and darkened @gray in the remaining instances.

This does slightly shift the colors in a few outcomes, but each seemed very minor. While this does make it a bit more arduous to manage the various shades of gray, it makes the variables file much more useful for making sweeping changes in lightness, darkness, or tint by simply changing the @gray variable.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/nchapman/master