Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10753

Using Bower verify to ensure bootstrap is compatible with jquery versions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/mokkabonna/bower-verify into master Sep 21, 2013
  • Overview 0
  • Commits 5
  • Pipelines 0
  • Changes 5

Created by: mokkabonna

Commit messages like this and other like it in different projects inspired me to create grunt-bower-verify that installs all tagged versions of bower dependencies and runs tasks after each iteration.

This allows bower package creators to be liberal when defining their dependencies, and confident that the automated testing will reveal any incompatibilities due to changes in their package or in their dependencies.

I have setup bootstrap to run this full test for each jquery version in travis only. Also put a lower version of jquery, as it is in fact compatible with jquery 1.7 (not 1.6 as it does not have on for events)

See the summary of the testing on this line: https://travis-ci.org/mokkabonna/bootstrap/builds/11639893#L1527

I had to reference the bower installed version of jquery in the test, and deleted the old one. This means that running the test locally will not work unless you first run bower install. This could also be automated if preferred, ensuring bower dependencies are installed on each run of grunt test, using grunt-bower-task, or simply solved with a simple update to the readme that for development bower is required after checkout.

If this PR is accepted, let me know which approach is preferable and I'll implement that as well.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mokkabonna/bower-verify