Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10778

Use updated Glyphicons to workaround old Android WebKit bug

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge old-android-glyphicons-fix into master Sep 24, 2013
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 11

Created by: cvrebert

Fixes #10106 (closed). There is a backwards-compatibility concern here, in that the codepoint changes will break stuff that uses the codepoints directly (e.g. entering one directly into HTML, using an &-escape to represent one in HTML, writing a custom .glyphicon-* equivalent, etc.), as opposed to our .glyphicon-* classes. On the other hand, we didn't document the codepoint numbers or recommend usage of them, so they are arguably not part of our public "API".

(Note: I don't have an Android device of appropriate vintage, so I can't fully test this myself. But the changes make sense theoretically, and I have tested that the icons still display fine on unaffected browsers.)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: old-android-glyphicons-fix