Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !10834

Only preventDefault on click on [data-toggle="modal"] when the element is a link

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/Prinzhorn/master into master Sep 27, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: Prinzhorn

In it's current state Bootstrap always prevents the default action for a click event on [data-toggle="modal"] elements (see https://github.com/twbs/bootstrap/blob/master/js/modal.js#L233). Instead this should only happen when the element is a link.

Why? I'm opening a modal when the user chooses a particular radio button. But with the current Bootstrap version the radio button won't get selected, but the modal opens. I think the only reason why preventDefault is needed is to prevent the hash from appearing in the URL (and thus the browser from jumping to the top or said hash).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/Prinzhorn/master