Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11048

Enable Close Dropdown on Toggle Click

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/YodasWs/master into master Oct 11, 2013
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 3

Created by: YodasWs

In Chrome with Zepto, clicking on the dropdown toggle button when the dropdown was open would not close the dropdown. This appears to be because click.bs.dropdown.data-api fires on the document first to call clearMenus(), making Dropdown.prototype.toggle see a closed dropdown to open again.

This update replaces Dropdown.prototype.toggle's call to clearMenus with its own code. clearMenus also needs to be escaped if the event target is the dropdown toggle button.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/YodasWs/master