Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11050

Restore grid mixins

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mark Otto requested to merge restore_grid_mixins into master Oct 12, 2013
  • Overview 0
  • Commits 4
  • Pipelines 0
  • Changes 7

Combines the efforts of #9970 and #10055 to fix #9436 (closed).

There were a few things I like about both approaches, and so I spent a few minutes bringing the two together for a more cohesive grid system generator. It's still a bit hairy, but I'm hoping some folks with more mixin chops can help me see if there is room for improvement.

A few thoughts, comments, caveats, etc:

  • We cannot use attribute selectors (meaning no [class^="col-"])
  • We cannot float everything all the time, that breaks the stacking of columns below their breakpoints (e.g., a medium grid column should be stacked in small view ports)
  • The number of mixins is kind of outrageous for generating our mixins and providing generic mixins to generate your own classes. I'm unsure of a way to improve this :.

That said, this brings back an amazing tool for folks and I think no matter how it changes from here, it's a solid win for 3.0.1.

/cc @cvrebert @masterbee

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: restore_grid_mixins