Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11142
An error occurred while fetching the assigned milestone of the selected merge_request.

Make better use of dropdown caret size variables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/santialbo/fix-carets into master 11 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: santialbo

This is more a variable name concept fix rather than a bug fix.

  • @caret-width-large was not being used for setting the height of the caret, now it is.
  • Caret width was twice @caret-width-base, I doubled the value and make the caret width to correspond with it.
Compare
  • master (base)

and
  • latest version
    6303c2f2
    1 commit, 2 years ago

2 files
+ 4
- 4

    Preferences

    File browser
    Compare changes
le‎ss‎
dropdow‎ns.less‎ +3 -3
variabl‎es.less‎ +1 -1
less/dropdowns.less
+ 3
- 3
  • View file @ 6303c2f2


@@ -10,9 +10,9 @@
height: 0;
margin-left: 2px;
vertical-align: middle;
border-top: @caret-width-base solid @dropdown-caret-color;
border-right: @caret-width-base solid transparent;
border-left: @caret-width-base solid transparent;
border-top: @caret-width-large solid @dropdown-caret-color;
border-right: @caret-width-base/2 solid transparent;
border-left: @caret-width-base/2 solid transparent;
// Firefox fix for https://github.com/twbs/bootstrap/issues/9538. Once fixed,
// we can just straight up remove this.
border-bottom: 0 dotted;
less/variables.less
+ 1
- 1
  • View file @ 6303c2f2


@@ -94,7 +94,7 @@
@component-active-color: #fff;
@component-active-bg: @brand-primary;
@caret-width-base: 4px;
@caret-width-base: 8px;
@caret-width-large: 5px;
// Tables
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
0
0 participants
Reference:
Source branch: github/fork/santialbo/fix-carets

Menu

Explore Projects Groups Snippets