Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11174

ceil @input-height-large calculation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/yokomizor/ceil_input_height_large_calculation into master Oct 19, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: yokomizor

This is the current @input-height-large calculation:

@input-height-large: (floor(@font-size-large * @line-height-large) + (@padding-large-vertical * 2) + 2);

or

@input-height-large: (floor(18 * 1.33) + (10 * 2) + 2);

I've noticed that: 18 * 1.31 = 23.58 18 * 1.3 = 23.4

I've been looking for #10936 (closed) and I've noticed that when line-height of .input-group-addon is 1.30 it looks fine, but when line-height is 1.31 it breaks on FF 24 OSX.

Maybe FF rounds up line-height, so I think it is safer to round this value up with ceil().

I hope this fix #10936 (closed) and #10482 (closed). I've tested on FF 24 OSX and it works fine.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/yokomizor/ceil_input_height_large_calculation