Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11281

When opening the dropdown, focus() the toggle BEFORE triggering 'shown' event

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/colllin/patch-1 into master Oct 30, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: colllin

This is as much a question as it is a pull request. Is there a reason for calling $this.focus() AFTER triggering the 'shown' event? I've come across this multiple times now where I bind to the 'shown' event and try to focus() into an text input when the dropdown is shown. For example, if the dropdown menu has a text input in it. I can get around it by setting a timeout, and that doesn't bother me too much, but if it's all the same to you, maybe we should just flip the order here?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/colllin/patch-1