Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11642

removed all caret border color settings.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/tlindig/caret_color_fix into master Nov 28, 2013
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 12

Created by: tlindig

In most cases, caret color should be same as text color.

You tried to get this by setting border-color in many places to the color of text. But not in all cases. For instance for buttons with other state than the default state, it is set to #fff instead of using color-variables of states and handling for :hover I missing completely.

But for what all this overhead?

Why you do not use the default behavior of border-color? The default is, if it is not specified, the text color will be used. And that is exact what we want, isn't?

In this pull request I removed all the border-color setting for caret.

Please give it a try.

It would simplify the Bootstrap CSS and give everybody the chance, to set a caret color by simply set the color property for class .caret.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tlindig/caret_color_fix