Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11931

WIP: Add RTL support

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Mark Otto requested to merge rtl into master Dec 19, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 7

This is a heavily WIP pull request to add RTL support to v3.1.

Strategy

There are two primary ways to implement RTL: rewrite the core files to include mixins for directional properties, or a separate optional file. I've opted for the latter here.

Implementation

This stubs out the ground work for adding RTL by updating the Gruntfile to compile and minify the CSS files for bootstrap-rtl.css from rtl.less. It also adds an example, based on the Theme example, to showcase the changes. Currently it looks like this:

screen shot 2013-12-18 at 8 40 04 pm screen shot 2013-12-18 at 8 40 42 pm

Feedback

I'm pausing here to get feedback from folks. This results in a lot of duplicate code, which sucks in some ways and doesn't in others. I'd love for folks to weigh in on things to be aware of, alternate implementations, bugs in what I've done thus far, oversights, etc.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rtl