Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !11958

move call for removeBackdrop() to backdrop()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tlindig/tl_modal_removeBackdrop_in_backdorp into master Dec 20, 2013
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: tlindig

function backdrop has a part, where the backdrop fade out is started. But the function removeBackdrop() was then called in 'hideModal'. That is not the optimal place for this.

It makes more difficult to extend to modal class, because it must be override more functions than it ought to be.

For instance I would like to implements a different handling for backdrop. With the change of this pull request, I only have to overwrite the backdorp function.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tlindig/tl_modal_removeBackdrop_in_backdorp