Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !12140

border-[top/right/bottom/left]-radius should check for negative radius

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tomyam1/master into master Jan 07, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: tomyam1

The border-top-radius, border-right-radius, border-bottom-radius and border-left-radius mixins are sometime used with subtracted variables, e.g.

.panel-heading {
  .border-top-radius((@panel-border-radius - 1));

this can easily result in passing negative values (resulting in invalid border-radius values), e.g. bootswatch's Yeti theme.

I think it's better to protect against it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tomyam1/master