Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !132

Text rendering fix for Android (and arguably for Windows)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/commonsense/master into master 13 years ago
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 3

Created by: rspeer

I understand that your project doesn't officially support WebKit on Android as a browser, but it's a shame to have Bootstrap sites be garbled on Android when they don't have to be. I've found the CSS rule that was causing failure on Android (text-rendering: optimizeLegibility) and commented it out.

As a side effect of removing this line, I have found that fonts on my site render much better on Windows. The "optimizeLegibility" declaration was causing Windows to adopt an aggressive hinting strategy that actively changed the heights of some glyphs, giving text a haphazard appearance.

Of course, you should weigh this benefit against whatever motivation you had to include that rule.

Compare
  • master (base)

and
  • latest version
    d7764b3c
    1 commit, 2 years ago

3 files
+ 7
- 4

    Preferences

    File browser
    Compare changes
l‎ib‎
scaffold‎ing.less‎ +5 -1
bootstrap‎-1.1.1.css‎ +1 -2
bootstrap-1‎.1.1.min.css‎ +1 -1
lib/scaffolding.less
+ 5
- 1
  • View file @ d7764b3c


@@ -77,7 +77,11 @@ body {
margin: 0;
#font > .sans-serif(normal,@basefont,@baseline);
color: @gray;
text-rendering: optimizeLegibility;
// The following line breaks text rendering on Android and degrades it on
// Windows:
//
// text-rendering: optimizeLegibility;
}
// Container (centered, fixed-width layouts)
bootstrap-1.1.1.css
+ 1
- 2
  • View file @ d7764b3c


@@ -6,7 +6,7 @@
* http://www.apache.org/licenses/LICENSE-2.0
*
* Designed and built with all the love in the world @twitter by @mdo and @fat.
* Date: Fri Aug 26 19:31:44 PDT 2011
* Date: Wed Aug 31 14:03:54 EDT 2011
*/
/* Reset.less
* Props to Eric Meyer (meyerweb.com) for his CSS reset file. We're using an adapted version here that cuts out some of the reset HTML elements we will never need here (i.e., dfn, samp, etc).
@@ -394,7 +394,6 @@ body {
font-weight: normal;
line-height: 18px;
color: #808080;
text-rendering: optimizeLegibility;
}
.container {
width: 940px;
bootstrap-1.1.1.min.css
+ 1
- 1
  • View file @ d7764b3c


@@ -61,7 +61,7 @@ table{border-collapse:collapse;border-spacing:0;}
.row .offset11{margin-left:680px;}
.row .offset12{margin-left:740px;}
html,body{background-color:#fff;}
body{margin:0;font-family:"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-weight:normal;line-height:18px;color:#808080;text-rendering:optimizeLegibility;}
body{margin:0;font-family:"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:13px;font-weight:normal;line-height:18px;color:#808080;}
.container{width:940px;margin:0 auto;}
.container-fluid{padding:0 20px;zoom:1;margin-bottom:18px;}.container-fluid:before,.container-fluid:after{display:table;content:"";}
.container-fluid:after{clear:both;}
0 Assignees
None
Assign to
0 Reviewers
None
Request review from
Labels
1
css
1
css
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
No estimate or time spent
Lock merge request
Unlocked
1
1 participant
Administrator
Reference: twbs/bootstrap!132
Source branch: github/fork/commonsense/master

Menu

Explore Projects Groups Snippets