Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13220

Scrollspy generates wrong offsets for a page-- recalculate offsets if `scrollheight` changes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/pconerly/fix-scrollspy-heightchange-bug into master Mar 28, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: pconerly

I have a long landing page that has a lot of images, and occasionally the images load after scrollspy's offset has been generated. The result is that the offset array generated is wrong and it will highlight the wrong images.

Looking at the code in scrollspy.js, there is no detection for a change in document height.

So here's the fix!

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/pconerly/fix-scrollspy-heightchange-bug