Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13286

Fixed issue with multiple CSS transitions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/tdolsen/master into master Apr 06, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: tdolsen

Fixed an issue with the transitions of the carousel, which failed to apply the next, prev, left and right classes when more than one CSS transition was set. This was due to multiple durations being returned as a comma-separated list (e.g. ".6s, 2s") which slice(0, 1) * 1000 would turn into a NaN.

The fix adds another function, findDuration, to the emulateTransitionEnd flow, which returns the highest duration in the comma-separated list as milliseconds. The function won't interfere with existing uses, as integers are ignored.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/tdolsen/master