Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13372

Simplify customisation of line height

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/thomaswelton/line-height-target into master Apr 17, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 2

Created by: thomaswelton

Added new variable @line-height-target with a default value to 20px to match the existing style. Then updated @line-height-base so it was no longer a magic number with a comment of 20 / 14

Seeing as this value was using math I've made it more explicit. The @line-height-base is now a unitless value derived from the base font size and new line height target.

Seeing as now the @line-height-base is variable driven I removed it from the customiser along with@line-height-computed I think this may make it easier for people to customise the variables file and get the values they want without have to do the math themselves, and seems a lot more explicit.

Note: Would this now make @line-height-computed redundant? I've kept it it for compatibility but could this variable become deprecated in a future release?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/thomaswelton/line-height-target