Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13497

replace js test for scrollspy default behavior

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/breaddevil/scrollspy-js-tests into master May 04, 2014
  • Overview 0
  • Commits 3
  • Pipelines 0
  • Changes 1

Created by: breaddevil

The "should switch active class on scroll" test looked incorrect to me so I replaced it. In this case ok($topbar.find('.active')) was always truthy.

I'm not very experienced with qunit and used promises to make the tests pass, I'm not sure if that is a good practice. I also would have preferred to make separate tests with a setup but qunit doesn't support "sub modules" yet.

I wrote more tests and will submit them if this one is approved (if code style is ok etc).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/breaddevil/scrollspy-js-tests