Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13597

Add option called 'remotePlacement' for modals

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Administrator requested to merge github/fork/gastlich/remote-placement-modal-option into master May 13, 2014
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 1

Created by: gastlich

In default, when option 'remote' is passed to modal, element with the selector '.modal-content' (according to documentation http://getbootstrap.com/javascript/#modals ) will be replaced with gathered remote content. In some cases we don't want to lose header/footer section of the modal, which have to be inside '.modal-content' element (stylesheets rules are applied for section header/footer inside '.modal-content').

This option may decrease the number of duplicated code: We can image that, page can have one default template for modals (including HTML structure and stylesheets for header/footer) and only content is different. We don't want to have header/footer structure in every remote content source, so the header/footer should be kept.

This option will be more powerful, when pull request #13183 will be merged, and it will allow to specify if modal's content should be erased on close or not.

<button data-toggle="modal" data-target="..." data-remote="..." data-remote-placement=".modal-body">
  Launch demo modal
</button>

remote-placement-modal

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/gastlich/remote-placement-modal-option