Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • B bootstrap
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 263
    • Issues 263
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 114
    • Merge requests 114
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Bootstrap
  • bootstrap
  • Merge requests
  • !13707

removing unnecessary max-width on tables

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Administrator requested to merge github/fork/bcullman/bcullman-remove-table-max-width into master May 29, 2014
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: bcullman

From the history, it appears max-width was added to tables.less when various css declarations originating in reset.less were relocated to appropriate less files so that reset.less could be removed in favor of normalize.less.

However, this max-width declaration did not come from Eric Meyer's reset.less. Instead, it was added in the following check-in by @mdo "help tables not look like shit on mobile maybe?"

https://github.com/twbs/bootstrap/commit/97b285896f50bed4a66b00a70ed67eb3224bc7f3

I don't believe that this declaration has proven it helps layouts on mobile. However it does cause layout problems when using bootstrap in conjunction with other javascript libraries.

If the original implementation was iffy to begin with, lets just remove it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/bcullman/bcullman-remove-table-max-width