Skip to content
GitLab

UMD code style

Closed Administrator requested to merge github/fork/hnrch02/fix-umd into master

Created by: hnrch02

This includes three rather controversial things: 1.

  1. Renames the argument of the UMD function to factory from o_o
  2. Subsequently re-enables requireCamelCaseOrUpperCaseIdentifiers for JSCS
    1. Re-enables the strict rule of JSHint
    2. Adds /* jshint strict: false */ to the function (as suggested by @XhmikosR)
  4. Replaces === in favor of == in the UMD function to comply with the currently used comparator with typeof in the rest of the codebase. (Ref)

This is why I have split this into two easy-to-revert commits, in case the hopefully vivid discussion following this PR concludes that something should be removed.

/cc @fat @cvrebert

(Remember, make love, not war <3)